fix(model_loader): drop deprecated resume_download kwarg#2053
Open
romanbsd wants to merge 2 commits into
Open
Conversation
Collaborator
|
@romanbsd Thanks for your contribution :) |
Collaborator
|
Thanks for the clean split, @romanbsd. The One issue: monkeypatch.setitem(sys.modules, "scipy", SimpleNamespace())
monkeypatch.setitem(sys.modules, "scipy.special", SimpleNamespace(expit=lambda x: x)) |
…etrained Recent transformers releases removed the `resume_download` argument from `from_pretrained`, so passing `resume_download=None` raises a TypeError. Use the default API and add unit tests covering the three loaders. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
load_text_multilabel_classifier imports scipy.special.expit at call time; mock it alongside the existing transformers/torch mocks so the test doesn't require scipy installed.
romanbsd
force-pushed
the
fix/model-loader-resume-download
branch
from
0eee2d2 to
a827019
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split out of #2046 as the first of three focused PRs, per @ntohidi's review request.
Recent
transformersreleases removed theresume_downloadargument fromfrom_pretrained, so passingresume_download=Noneraises aTypeError. This drops the deprecated kwarg from the three model loaders and adds unit tests that assert the loaders callfrom_pretrainedwith the current API (noresume_download).Changes
crawl4ai/model_loader.py— removeresume_download=Nonefromload_bert_base_uncased,load_HF_embedding_model,load_text_multilabel_classifiertests/unit/test_model_loader_transformers.py— new tests (mock transformers, no network/model download)Testing
pytest tests/unit/test_model_loader_transformers.py— 3 passed.Follow-ups from the same review: dependency bumps are in two separate PRs (minor/patch, and major).
🤖 Generated with Claude Code